Enable preview-dart-2 by default #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re: the failure here: https://travis-ci.org/dart-lang/dartdoc/jobs/352522502#L547 - you may want to try symlinking in the latest analyzer/front_end/kernel sources from the sdk, and see if the failure repros. |
|
Yes, already did that. It doesn't reproduce there. We need a new version of the analyzer. |
|
New version of analyzer published, and updated PR. |
devoncarew
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1640.
Based on discussion in dart 2.0 planning doc, enable the analyzer's preview-dart-2 equivalent option. Added missing new and const cases to make sure it works.