Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3030. Add additional test checking non const in a const constructor initializer list #3036

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jan 7, 2025

Github shows a wrong diff as if ..._02 was renamed to ...t03 and ...t03 to ...t02. Hope that it won't be a problem for the review.

…st constructor initializer list
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit cd4e02a into dart-lang:master Jan 9, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 10, 2025
2025-01-10 [email protected] Fixes dart-lang/co19#3039. Fix the new roll failures (dart-lang/co19#3040)
2025-01-10 [email protected] dart-lang/co19#2976. Add constant expressions tests. Part 4. (dart-lang/co19#3037)
2025-01-09 [email protected] dart-lang/co19#2976. Add constant expressions tests (dart-lang/co19#3024)
2025-01-09 [email protected] Fixes dart-lang/co19#3030. Add additional test checking non const in a const constructor initializer list (dart-lang/co19#3036)
2025-01-09 [email protected] dart-lang/co19#2976. Add grammar tests for shorthand with different operators. (dart-lang/co19#3027)
2025-01-08 [email protected] Fixes dart-lang/co19#3028. Add tests for mixin application constant constructor (dart-lang/co19#3032)
2025-01-08 [email protected] dart-lang/co19#2976. Add constant expressions tests.Part 3. (dart-lang/co19#3026)
2025-01-08 [email protected] dart-lang/co19#2976. Add constant expressions tests.Part 2. (dart-lang/co19#3025)
2025-01-06 [email protected] dart-lang/co19#2976. Add more equality tests (dart-lang/co19#3023)
2025-01-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 4.5.0 to 4.6.0 in the github-actions group (dart-lang/co19#3033)
2024-12-20 [email protected] dart-lang/co19#2976. Add more tests for shorthand equality (dart-lang/co19#3022)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ic8becbc8de5c560f3e9294a47d727442df7c733f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403982
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants