-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2976. Add more type inference tests #3004
Conversation
Sorry, it's not ready for the review yet. Converted to a draft. |
Ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of comments.
LanguageFeatures/Static-access-shorthand/type_inference_A02_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A02_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A03_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A03_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A04_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A04_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. PTAL.
LanguageFeatures/Static-access-shorthand/type_inference_A02_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A02_t05.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A03_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A03_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Static-access-shorthand/type_inference_A04_t01.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2024-12-06 [email protected] Fixes dart-lang/co19#3008. Rewrite type_inference_A01_t06.dart to get the context type _ (dart-lang/co19#3009) 2024-12-06 [email protected] Fixes dart-lang/co19#3006. Fix a typo in type_inference_A01_t06.dart (dart-lang/co19#3007) 2024-12-06 [email protected] dart-lang/co19#2976. Add type inference tests. Part 2 (dart-lang/co19#3005) 2024-12-05 [email protected] dart-lang/co19#2976. Add more type inference tests (dart-lang/co19#3004) 2024-12-04 [email protected] dart-lang/co19#2976. Add grammar, semantics and type inference test for constants (dart-lang/co19#3003) 2024-11-29 [email protected] dart-lang/co19#2976. Add more grammar, semantics and type inference test (dart-lang/co19#3002) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ie10a17900bc7d61d4f9288d3e3d2f359eca4f1d9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399400 Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
No description provided.