Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2933. Add MultiStreamController tests. Part 3. #2940

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

sgrekhov
Copy link
Contributor

No description provided.

controller.add(4);
controller.addSync(5);
controller.addError(6);
controller.addSync(7);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be addErrorSync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! Fixed.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit bdab922 into dart-lang:master Oct 18, 2024
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 25, 2024
2024-10-24 [email protected] dart-lang/co19#2386. Update super-bounded types tests (dart-lang/co19#2942)
2024-10-23 [email protected] dart-lang/co19#1400. Add extension types tests for bottom types (dart-lang/co19#2944)
2024-10-18 [email protected] dart-lang/co19#2933. Add MultiStreamController tests. Part 3. (dart-lang/co19#2940)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Id9774ab53b5451962efb1d3c3790725620fd322c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391940
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants