Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2419. Add missing int ~/ double constants expression #2444

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Fix typo: `;` should be `,`.
@eernstg eernstg merged commit 67478ce into dart-lang:master Dec 19, 2023
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Dec 28, 2023
2023-12-21 [email protected] dart-lang/co19#1400. Add the trivial case and a pattern check (dart-lang/co19#2451)
2023-12-21 [email protected] Fixes dart-lang/co19#2446. Update cast-pattern exhaustiveness tests according to the changed spec (dart-lang/co19#2448)
2023-12-20 [email protected] Fixes dart-lang/co19#2445. Add safety margin for Timer.periodic and check negative duration (dart-lang/co19#2447)
2023-12-19 [email protected] dart-lang/co19#2419. Add missing int ~/ double constants expression (dart-lang/co19#2444)
2023-12-19 [email protected] Fixes dart-lang/co19#2419. Add/update tests according to the recent spec changes (dart-lang/co19#2442)

Change-Id: Ifbfc6c1f442ac236ce16770526991a6653b8041c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/343380
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Jonas Termansen <[email protected]>
@sgrekhov sgrekhov deleted the co19-2419-2 branch January 21, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants