Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1400. File delete/rename commit #2072

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jun 2, 2023

static_analysis_inline_class_A09_t01.dart and static_analysis_inline_class_A10_t01.dart were deleted. Other tests renamed to fill a gap in enumeration

@sgrekhov sgrekhov requested a review from eernstg June 2, 2023 09:11
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Github gets seriously confused about file renames. It's a really good idea to keep this confusion out of regular PRs.

LGTM!

@eernstg eernstg merged commit af3a268 into dart-lang:master Jun 2, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jun 9, 2023
2023-06-07 [email protected] dart-lang/co19#1400. File renaming commit (dart-lang/co19#2075)
2023-06-07 [email protected] Fixes for socket tests (dart-lang/co19#2074)
2023-06-07 [email protected] dart-lang/co19#1400. Static analysis of inline class tests. Part 3 (dart-lang/co19#2071)
2023-06-02 [email protected] dart-lang/co19#1400. File delete/rename commit (dart-lang/co19#2072)
2023-06-02 [email protected] dart-lang/co19#1400. More static analysis of the inline class tests (dart-lang/co19#2068)

Change-Id: I3dae7126e2714e152d60de764b95d3d4d1c8b3d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/308300
Reviewed-by: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-1400-8 branch July 18, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants