The file co19/src/Utils/test_mode_check.dart uses the name 'dart_precompiled_runtime' to determine mode which could be incorrect #2943
Assignees
Comments
|
I'll update it after landing of https://dart-review.googlesource.com/c/sdk/+/389760 |
|
@a-siva as far as I can see https://dart-review.googlesource.com/c/sdk/+/389760 was reverted. Please let me know if there is another CL replacing https://dart-review.googlesource.com/c/sdk/+/389760. Otherwise I'll go on checking of https://dart-review.googlesource.com/c/sdk/+/389760 and update the tests after the landing. |
|
I had to revert the CL a couple of times because of issues with the benchmark suite. I landed it yesterday |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this issue
Nov 15, 2024
2024-11-14 [email protected] dart-lang/co19#2956. Add more tests for the type `void` (dart-lang/co19#2977) 2024-11-12 [email protected] dart-lang/co19#2956. Rename, move and update existing return from `void` tests (dart-lang/co19#2975) 2024-11-12 [email protected] dart-lang/co19#2956. Add more type void tests. Update existing ones (dart-lang/co19#2974) 2024-11-11 [email protected] Fixes dart-lang/co19#2943. Use name `dartaotruntime` instead of `dart_precompiled_runtime` (dart-lang/co19#2973) 2024-11-11 [email protected] dart-lang/co19#2953. Add inference with bounds tests (dart-lang/co19#2957) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I1f3c534a1e69af28c9adb93bdc13b8741a64e7f8 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395500 Reviewed-by: Erik Ernst <[email protected]> Reviewed-by: Chloe Stefantsova <[email protected]> Commit-Queue: Erik Ernst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The CL https://dart-review.googlesource.com/c/sdk/+/389760 is making the name of the AOT executable consistent by using the
name '
dartaotruntime' (which is what the shipping Dart sdk uses). The executable 'dart_precompiled_runtime' in the build directories is being renamed to 'dartaotruntime'.The file co19/src/Utils/test_mode_check.dart uses the name '
dart_precompiled_runtime' to determine if the test is running in AOT mode, this breaks with the above change. The check needs to be modified to use 'dartaotruntime'The text was updated successfully, but these errors were encountered: