Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extension type] Add more constant evaluation tests #2383

Closed
sgrekhov opened this issue Nov 17, 2023 · 1 comment
Closed

[Extension type] Add more constant evaluation tests #2383

sgrekhov opened this issue Nov 17, 2023 · 1 comment
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

Add co19 test(s) based on example from dart-lang/sdk#54057
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 17, 2023
@sgrekhov sgrekhov self-assigned this Nov 17, 2023
@eernstg
Copy link
Member

eernstg commented Nov 17, 2023

Good catch!

We should double check one thing: @lrhn, are you about to add some language tests that are very similar to the examples in dart-lang/sdk#54057? In that case we'd get too much duplication by having very similar co19 tests as well.

However, it's still worth considering whether the examples in dart-lang/sdk#54057 could serve as inspiration for some similar tests that aren't directly covered, and then add some co19 tests for that. For example, canonicalization of function types where some subterms are extension types.

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 24, 2023
@sgrekhov
Fixes dart-lang#2383. Add more constant evaluation tests
8504135
@eernstg eernstg closed this as completed in 95141a4 Dec 4, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Dec 11, 2023
@sgrekhov
[co19] Roll co19 to ea5e476b3af94f74f6996e4b4319bf03f9248c1c
8763ece 
2023-12-07 [email protected] Fixes dart-lang/co19#2413. Add missing expected compile-time errors for CFE (dart-lang/co19#2418)
2023-12-07 [email protected] dart-lang/co19#2119. Run dart formatter on LibTest/async tests (dart-lang/co19#2417)
2023-12-06 [email protected] dart-lang/co19#2398. Make asyncStart/End() safe in LibTest/async (dart-lang/co19#2416)
2023-12-06 [email protected] Fixes dart-lang/co19#2355. Add more typed_date.setRange() tests (dart-lang/co19#2412)
2023-12-06 [email protected] dart-lang/co19#2404. Small code-style improvements and description update (dart-lang/co19#2414)
2023-12-04 [email protected] dart-lang/co19#2004. Add deferred libraries tests according to the changed spec (dart-lang/co19#2411)
2023-12-04 [email protected] Fixes dart-lang/co19#2383. Add more constant evaluation tests (dart-lang/co19#2396)

Change-Id: I15e0d681538fa0f2a311f74d1930fad7270b81a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/340561
Commit-Queue: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg