Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

co19/LanguageFeatures/Super-parameters/type_inference_A04_t04 #1268

Closed
scheglov opened this issue Jan 13, 2022 · 0 comments
Closed

co19/LanguageFeatures/Super-parameters/type_inference_A04_t04 #1268

scheglov opened this issue Jan 13, 2022 · 0 comments
Assignees
@sgrekhov

Comments

@scheglov
Copy link 

FAILED: dart2analyzer-none release_x64 co19/LanguageFeatures/Super-parameters/type_inference_A04_t04
Expected: Pass
Actual: CompileTimeError

--- Command "dart2analyzer" (took 33ms):
DART_CONFIGURATION=ReleaseX64 sdk/bin/dartanalyzer --enable-experiment=super-parameters --ignore-unrecognized-flags --packages=/Users/scheglov/Source/Dart/sdk.git/sdk/.packages --format=json --no-hints /Users/scheglov/Source/Dart/sdk.git/sdk/tests/co19/src/LanguageFeatures/Super-parameters/type_inference_A04_t04.dart

unexpected analysis errors in type_inference_A04_t04.dart:
- Line 36, column 14: COMPILE_TIME_ERROR.ARGUMENT_TYPE_NOT_ASSIGNABLE
  The argument type 'Object?' can't be assigned to the parameter type 'String'.

unexpected analysis errors in ../../Utils/expect_common.dart:
- Line 253, column 11: TODO.TODO
  TODO check that key sets are equivalent.

--- Re-run this test:
python3 tools/test.py -m release -c dart2analyzer co19/LanguageFeatures/Super-parameters/type_inference_A04_t04
@sgrekhov sgrekhov self-assigned this Jan 14, 2022
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jan 20, 2022
@athomas
[co19] Roll co19 to 73fa4da0cb5a6fec136a2ac045503770eed2b58f
f783bac 
2022-01-19 [email protected] Fixes dart-lang/co19#1275: Test expectations corrected.
2022-01-18 [email protected] Fixes dart-lang/co19#1274: LanguageFeatures/Super-parameters/summary_A04_t02 test corrected: Expect.approxEquals is used instead of Expect.equals for the double comparing.
2022-01-18 [email protected] Issue dart-lang/co19#1244: LanguageFeatures/Constructor-tear-offs/unnamed_constructor_A06_t01 test should not run for dart2js because it uses mirrors.
2022-01-14 [email protected] dart-lang/co19#1262. Roll failures fixed
2022-01-14 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests added
2022-01-14 [email protected] Fixes dart-lang/co19#1269. Missed default constructor added to enum declaration
2022-01-14 [email protected] Fixes dart-lang/co19#1273. Typo fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1271. Typo fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1270. Fix expected result values
2022-01-14 [email protected] Fixes dart-lang/co19#1268. Runtime type check fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1267. Error expectation added
2022-01-14 [email protected] Fixes dart-lang/co19#1266. Default value added to non-nullable parameter
2022-01-14 [email protected] Fixes dart-lang/co19#1272. Runtime type check fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1265. Invalid assignment fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1264. Super parameter name fixed
2022-01-14 [email protected] Fixes dart-lang/co19#1263. Add default value to non-nullable parameter
2022-01-13 [email protected] dart-lang/co19#1258. Enhanced Enums semantics tests rewritten according to changed spec

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I7001196297890f485f4b506898fff8cff1b3a0d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/228646
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scheglov @sgrekhov