comment linter issues

dart-archive · May 20, 2016 · dd8ed1b · kevmoo · May 20, 2016 · pq
1 parent 83ae219
commit dd8ed1b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 0 deletions.
diff --git a/.analysis_options b/.analysis_options
@@ -0,0 +1,3 @@
+linter:
+  rules:
+    - comment_references
diff --git a/lib/src/class.dart b/lib/src/class.dart
@@ -44,6 +44,8 @@ class VMClassRef implements VMObjectRef {
 
   /// Evaluates [expression] in the context of this class.
   ///
+  /// -- A LOT of these – need a way to reference types in non-imported libs
+  /// --    requiring an import just for these would REALLY suck.
   /// Throws a [VMErrorException] if evaluating the expression throws an error.
   Future<VMInstanceRef> evaluate(String expression) =>
       _scope.evaluate(_id, expression);

diff --git a/lib/src/error.dart b/lib/src/error.dart
@@ -113,6 +113,7 @@ class VMErrorKind {
 
   /// An internal error.
   ///
+  /// --- boo! detecting a link as a reference. Easy to fix?
   /// These errors should not be exposed—if seen, they should be [reported as
   /// bugs](https://github.com/dart-lang/sdk/issues/new).
   static const internalError = const VMErrorKind._("InternalError");

diff --git a/lib/vm_service_client.dart b/lib/vm_service_client.dart
@@ -61,6 +61,7 @@ final _jsonSinkEncoder = new StreamSinkTransformer.fromHandlers(
 ///
 /// [service api]: https://github.com/dart-lang/sdk/blob/master/runtime/vm/service/service.md
 ///
+/// --- no clue why `connect` here is an error, but `getVM` is fine. Help?
 /// Connect to a VM service endpoint using [connect], and use [getVM] to load
 /// information about the VM itself.
 ///