Merge pull request #46 from dart-lang/fix-path

Support 2.3 paths

CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.2.6+2
+
+* Do not override path during `VMServiceClient.connect`.
+  * Fixes issues with connecting to Dart `2.3` observatory URIs.
+
 ## 0.2.6+1
 
 * Allow `stream_channel` version 2.x

lib/vm_service_client.dart

@@ -109,7 +109,10 @@ class VMServiceClient {
     }
 
     var uri = url is String ? Uri.parse(url) : url;
-    if (uri.scheme == 'http') uri = uri.replace(scheme: 'ws', path: '/ws');
+    if (uri.scheme == 'http') {
+      var path = uri.path.endsWith('/') ? uri.path : uri.path + '/';
+      uri = uri.replace(scheme: 'ws', path: '${path}ws');
+    }
 
     // TODO(nweiz): Just use [WebSocketChannel.connect] when cross-platform
     // libraries work.

pubspec.yaml

@@ -1,5 +1,5 @@
 name: vm_service_client
-version: 0.2.6+1
+version: 0.2.6+2
 description: A client for the Dart VM service.
 author: Dart Team <[email protected]>
 homepage: https://github.com/dart-lang/vm_service_client