Skip to content
This repository has been archived by the owner on Oct 18, 2024. It is now read-only.

Update min SDK to 2.4 #24

Merged
merged 2 commits into from
Jan 13, 2020
Merged

Update min SDK to 2.4 #24

merged 2 commits into from
Jan 13, 2020

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 12, 2020

Related to dart-lang/test#1141

@kevmoo kevmoo requested a review from natebosch January 12, 2020 01:37
@kevmoo kevmoo requested a review from jakemac53 January 13, 2020 19:13
CHANGELOG.md Outdated
@@ -1,3 +1,7 @@
## 1.1.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please put the -dev here too so it matches the pubspec version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're doing that now? Was there a "discussion" on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have always argued that they should always be in sync 🤷‍♂ . I am not aware of any agreed upon policy that is consistently used across repos though.

@kevmoo kevmoo merged commit 95c94f4 into master Jan 13, 2020
@kevmoo kevmoo deleted the dart_2_4 branch January 13, 2020 19:57
mosuem pushed a commit to dart-lang/core that referenced this pull request Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants