Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Fix #601: checkbox list separated with blank lines #602

Merged
merged 5 commits into from
May 22, 2024

Conversation

tomyeh
Copy link
Contributor

@tomyeh tomyeh commented Mar 28, 2024


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 9185260930

Details

  • 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 96.099%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/block_syntaxes/list_syntax.dart 6 7 85.71%
Totals Coverage Status
Change from base Build 8991131738: -0.05%
Covered Lines: 1552
Relevant Lines: 1615

💛 - Coveralls

Copy link
Collaborator

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, thanks!

@srawlins srawlins merged commit 340c76f into dart-archive:master May 22, 2024
8 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request May 23, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (https://github.com/dart-lang/dartdoc/compare/476d5cc..1e1a004):
  1e1a004c  2024-05-21  Sam Rawlins  Re-enable CI on stable channel (dart-lang/dartdoc#3774)

http (https://github.com/dart-lang/http/compare/5c01453..7df2ac8):
  7df2ac8  2024-05-22  Derek Xu  [package:http_profile] Update experimental status notice in README.md (dart-lang/http#1206)
  c8d5479  2024-05-21  Jonas Finnemann Jensen  Add `topics` to `pubspec.yaml` (dart-lang/http#1199)

markdown (https://github.com/dart-lang/markdown/compare/7463999..340c76f):
  340c76f  2024-05-22  Tom Yeh  Fix `#601`: checkbox list separated with blank lines (dart-archive/markdown#602)

path (https://github.com/dart-lang/path/compare/9be79e7..aea50fa):
  aea50fa  2024-05-21  Sarah Zakarias  Add `topics` to  `pubspec.yaml` (dart-archive/path#165)

Change-Id: I023714125518c53ed117b9115331148e54f3e0ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/367780
Auto-Submit: Devon Carew <[email protected]>
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 9, 2024
…art-archive/markdown#602)

* Fix dart-lang/markdown#586: encode image tag's src attribute

* Fix dart-lang/markdown#601: checkbox list separated with blank lines
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants