This repository was archived by the owner on Feb 24, 2025. It is now read-only.
fix a crash when parsing alert block syntax #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Pull Request Test Coverage Report for Build 8178324723Details
💛 - Coveralls |
devoncarew
commented
Mar 6, 2024
| @@ -21,8 +21,7 @@ class AlertBlockSyntax extends BlockSyntax { | |||
|
|
|||
| @override | |||
| bool canParse(BlockParser parser) { | |||
| return pattern.hasMatch(parser.current.content) && | |||
| parser.lines.any((line) => _contentLineRegExp.hasMatch(line.content)); | |||
| return alertPattern.hasMatch(parser.current.content); | |||
There was a problem hiding this comment.
Based on #585 (comment) and https://github.com/dart-lang/markdown/issues/579 I removed the reference here to BlockParser.lines; I suspect it caused quadratic parsing times.
srawlins
approved these changes
Mar 7, 2024
| @@ -21,8 +21,7 @@ class AlertBlockSyntax extends BlockSyntax { | |||
|
|
|||
| @override | |||
| bool canParse(BlockParser parser) { | |||
| return pattern.hasMatch(parser.current.content) && | |||
| parser.lines.any((line) => _contentLineRegExp.hasMatch(line.content)); | |||
| return alertPattern.hasMatch(parser.current.content); | |||
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Mar 7, 2024
…h, web, webdriver, webkit_inspection_protocol Revisions updated by `dart tools/rev_sdk_deps.dart`. dartdoc (https://github.com/dart-lang/dartdoc/compare/cec45fb..0de8aff): 0de8aff3 2024-03-06 Sam Rawlins Generate docs for enum static methods. (dart-lang/dartdoc#3697) 9eafdc64 2024-03-06 Sam Rawlins Rewrite Library.allOriginalModelElementNames. (dart-lang/dartdoc#3698) e8f36333 2024-03-06 Sam Rawlins Fix SDK GitHub action with some stub headers and footers (dart-lang/dartdoc#3704) 58c065d4 2024-03-05 Sam Rawlins Bump snippets activated to 0.4.3 (dart-lang/dartdoc#3702) http (https://github.com/dart-lang/http/compare/470d2c3..8d3c647): 8d3c647 2024-03-06 Brian Quinlan Add support for negotiating a subprotocol (dart-lang/http#1150) e71e739 2024-03-05 Brian Quinlan Add `WebSocket.connect` as a cross-platform connection method (dart-lang/http#1149) f14b5aa 2024-03-04 Brian Quinlan Include a description and version number in web_socket pubspec (dart-lang/http#1148) 5b656a9 2024-03-04 Brian Quinlan Add a LICENSE file to package:web_socket (dart-lang/http#1147) 557c420 2024-03-04 Brian Quinlan Implement WebSocket for the browser (dart-lang/http#1142) markdown (https://github.com/dart-lang/markdown/compare/dd47c5d..1ca5166): 1ca5166 2024-03-06 Devon Carew fix a crash when parsing alert block syntax (dart-archive/markdown#593) package_config (https://github.com/dart-lang/package_config/compare/4a7042b..3d90e69): 3d90e69 2024-03-05 Michael Thomsen Fix typo (dart-archive/package_config#149) shelf (https://github.com/dart-lang/shelf/compare/da6a69b..1acbc67): 1acbc67 2024-03-06 Andy Add shelf_router middleware examples (dart-lang/shelf#417) vector_math (https://github.com/google/vector_math.dart/compare/3706feb..7e705f7): 7e705f7 2024-03-06 6y Fix quaternion negate (google/vector_math.dart#316) 1ed8ac6 2024-03-06 6y Resolve Inconsistency in Matrix3 and Matrix4 `rotateY` Implementations (google/vector_math.dart#317) web (https://github.com/dart-lang/web/compare/8870d04..51e594b): 51e594b 2024-03-05 Srujan Gaddam Fix dictionary constructors to accept supertype members and create an empty object when there are no fields (dart-lang/web#197) 4af904f 2024-03-05 Srujan Gaddam Publish 0.5.1 (dart-lang/web#196) c72ec1a 2024-03-04 Devon Carew add instructions for re-generating the package (dart-lang/web#195) webdriver (https://github.com/google/webdriver.dart/compare/2c1b6f8..73a7ac8): 73a7ac8 2024-03-04 dependabot[bot] Bump nanasess/setup-chromedriver from 2.2.1 to 2.2.2 (google/webdriver.dart#294) webkit_inspection_protocol (https://github.com/google/webkit_inspection_protocol.dart/compare/07295b9..153fea4): 153fea4 2024-03-04 dependabot[bot] Bump nanasess/setup-chromedriver (google/webkit_inspection_protocol.dart#120) Change-Id: Ic213677a1e2430a6de56a94e0bfaa1f33e2fc7d4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356300 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 9, 2024
* fix a crash when parsing alert block syntax * update version.dart * Remove the reference to 'parser.lines' in canParse().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srawlins - this also revs the package version in preparation for publishing (so we can get the fix out for pub.dev).
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.