Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Bump min SDK to fix tests #28

Closed
wants to merge 1 commit into from
Closed

Bump min SDK to fix tests #28

wants to merge 1 commit into from

Conversation

kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Jan 14, 2020

Use chrome instead of firefox for browser tests on travis

Use chrome instead of firefox for browser tests on travis
@natebosch
Copy link
Contributor

We could fix the tests instead...

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 14, 2020

We could fix the tests instead...

Isn't this due to an SDK bug? That's my memory...

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 14, 2020

See dart-lang/test#1141

@natebosch
Copy link
Contributor

Yes, this is caused by an SDK bug. Rather than ignoring the fact that there is a version of package:test in the wild that no one can use on that SDK we should publish a version that works, then bump the dep in test.

dart-lang/test#1143

@kevmoo
Copy link
Contributor Author

kevmoo commented Jan 14, 2020

Good idea!

@kevmoo kevmoo closed this Jan 14, 2020
@kevmoo kevmoo deleted the fix_travis branch January 14, 2020 23:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants