Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Update devrun to use latest node.js #317

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Update devrun to use latest node.js #317

merged 1 commit into from
Oct 29, 2015

Conversation

ochafik
Copy link
Contributor

@ochafik ochafik commented Sep 12, 2015

Updates:

  • iojs was merged into node.js, v4 has good (enough) support for ES6 (note: can install with nvm: nvm install v4.0.0)
  • flags needed update (+ bumped min version)
  • globally-activated dartdevrun was failing to find its runtimeDir: fixed the corresponding logic.

@jmesserly
Copy link
Contributor

does node 4 work with Karma now? I tried it last week, had to uninstall because of a socket.io bug:
socketio/socket.io#2213 (comment)
nodejs/node#2798

so upgrading node to 4 will break our browser tests :|

@ochafik
Copy link
Contributor Author

ochafik commented Sep 14, 2015

Node4 still breaks karma, but when installing it with nvm in .travis.yml it doesn't seem to make it to the path so the tests still run fine.

(I've renamed NODE_BIN to NODE_4_BIN to make it clearer)

@jmesserly
Copy link
Contributor

yeah, can see that it passes on Travis, just wondering what to do locally? if I were to install node 4 I won't be able to run our browser tests, but if I don't install it I won't be able to run dartdevrun.

Maybe we can wait a bit until the relevant fixes for nodejs/node#2798 land?

@ochafik
Copy link
Contributor Author

ochafik commented Sep 15, 2015

Can wait or install both versions with nvm install v4.0.0; nvm install v0.12.7 and pass --v8-binary=$HOME/.nvm/versions/node/v4.0.0/bin/node (last one installed will be in path locally, can be switched with nvm use v0.12.7).

I've removed that part (will send as a separate PR on chromium reviews), kept the fixes for node 4 that I think should still go in :-)

@ochafik ochafik changed the title Update devrun to use latest node.js + test it in Travis. Update devrun to use latest node.js Oct 29, 2015
@jmesserly
Copy link
Contributor

Awesome! looks like everything merged now in upstream pkgs.

jmesserly pushed a commit that referenced this pull request Oct 29, 2015
Update devrun to use latest node.js
@jmesserly jmesserly merged commit 36a87f7 into master Oct 29, 2015
@jmesserly jmesserly deleted the fix-devrun branch October 29, 2015 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants