Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Enable and fix new lints #97

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 3.1.2-dev
## 3.1.2-wip

- Require Dart 3.0
- Add chunked decoding support (`startChunkedConversion`) for `CodePage`
Expand Down
5 changes: 0 additions & 5 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,12 @@ linter:
- avoid_unused_constructor_parameters
- avoid_void_async
- cancel_subscriptions
- comment_references
- literal_only_boolean_expressions
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- package_api_docs
- prefer_const_constructors
- prefer_const_declarations
- prefer_expression_function_bodies
- prefer_relative_imports
- test_types_in_equals
- unnecessary_await_in_return
- use_string_buffers
- use_super_parameters
6 changes: 3 additions & 3 deletions pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
name: convert
version: 3.1.2-dev
version: 3.1.2-wip
description: >-
Utilities for converting between data representations.
Provides a number of Sink, Codec, Decoder, and Encoder types.
repository: https://github.com/dart-lang/convert

environment:
sdk: '^3.0.0'
sdk: ^3.0.0

dependencies:
typed_data: ^1.3.0

dev_dependencies:
benchmark_harness: ^2.2.0
dart_flutter_team_lints: ^1.0.0
dart_flutter_team_lints: ^2.0.0
test: ^1.17.0
8 changes: 4 additions & 4 deletions test/hex_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -147,24 +147,24 @@ void main() {
expect(results, isEmpty);

sink.add('0');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('0');
expect(
results,
equals([
[],
<Never>[],
[0x00]
]));

sink.add('');
expect(
results,
equals([
[],
<Never>[],
[0x00]
]));
});
Expand Down
10 changes: 5 additions & 5 deletions test/percent_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -154,22 +154,22 @@ void main() {
expect(results, isEmpty);

sink.add('%');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('2');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('');
expect(results, equals([[]]));
expect(results, equals([<Never>[]]));

sink.add('0');
expect(
results,
equals([
[],
<Never>[],
[0x20]
]));
});
Expand Down