blast_repo fixes #75
blast_repo fixes #75
Conversation
auto-publish
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
|
@lrhn - this PR updates dart-lang/characters to use some publishing automation. To use it, you'll want to merge this PR, then tag the merged commit w/ the above version tag ( |
README.md
Outdated
| @@ -131,3 +131,8 @@ Characters firstTagCharacters(Characters source) { | |||
| [String]: https://api.dart.dev/stable/2.0.0/dart-core/String-class.html "String class" | |||
| [Uint16List]: https://api.dart.dev/stable/2.0.0/dart-typed_data/Uint16List-class.html "Uint16List class" | |||
| [Uint8List]: https://api.dart.dev/stable/2.0.0/dart-typed_data/Uint8List-class.html "Uint8List class" | |||
|
|
|||
There was a problem hiding this comment.
I'm meh on the update to the readme. It ONLY affects managers of the package, but it creates noise on every pub.dev page. I think we should drop it!
There was a problem hiding this comment.
I can drop it. When contributing publishing automation to a mono-repo we can document on the main readme; it'll be helpful for people to better understand the workflow for contributing. And I'm less concerned now with adding repo smarts to all the individual single package repos, and instead make sure our mono-repos get all the latest automation.
There was a problem hiding this comment.
Consider having a PUBLISHING.md file with documentation about how to publish.
The README.md is for end-users, not developers.
| pull_request: | ||
| branches: [ master ] | ||
| push: | ||
| tags: [ 'v[0-9]+.[0-9]+.[0-9]+*' ] |
There was a problem hiding this comment.
(I think this is a glorified glob pattern, not a regexp. Very confusing to read 🤔.)
The pattern can drop the last +. It's probably benign, I don't think a glob pattern can get catastrophic backtracking, especially when there is nothing after the *. With any luck, the implementation will go to the * after seeing the first digit.
There was a problem hiding this comment.
The pattern was intended to be able to capture x.y.x-something, for completeness. But thinking about it, if we really only ever intend to support publishing release versions via this automation, than dropping the suffix makes sense.
* blast_repo fixes auto-publish * Update README.md
auto-publish