This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
Switch to package:lints #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrhn
reviewed
May 25, 2021
lib/src/characters_impl.dart
Outdated
| if (element.isEmpty) return false; | ||
| var next = | ||
| Breaks(element, 0, element.length, stateSoTNoBreak).nextBreak(); | ||
| if (next != element.length) return false; | ||
| // [other] is single grapheme cluster. |
There was a problem hiding this comment.
Comment's "other" refers to "element" too, and should be renamed as well
|
Remarkably few changes needed. Good to see! Fix the comment, then it's LGTM. |
lrhn
approved these changes
May 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.