This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
fix(ngControl): unregister control from parent on detach #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un-register a control with its parent on detach, and also move register call to attach(). Right now, when a form element(such as an input) is removed from the dom, the parent control does not remove it from the list of controls.
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Mar 6, 2014
Un-register a control with its parent on detach, and also move register call to attach(). Right now, when a form element(such as an input) is removed from the dom, the parent control does not remove it from the list of controls. Closes dart-archive#684
mhevery
pushed a commit
to mhevery/angular.dart
that referenced
this pull request
Mar 6, 2014
Un-register a control with its parent on detach, and also move register call to attach(). Right now, when a form element(such as an input) is removed from the dom, the parent control does not remove it from the list of controls. Closes dart-archive#684
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Un-register a control with its parent on detach, and also move register call to attach().
Right now, when a form element(such as an input) is removed from the dom,
the parent control does not remove it from the list of controls.