Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

feat(WTF): Add support for WTF #1354

Closed
wants to merge 1 commit into from
Closed

Conversation

mhevery
Copy link
Contributor

@mhevery mhevery commented Aug 14, 2014

@chirayuk
Copy link
Contributor

Travis fails due to failing import of dart:js for the command line VM: https://travis-ci.org/angular/angular.dart/jobs/32510438

<meta charset="UTF-8">
<title>WTF Test page</title>
<script src="wtf.dart" type="application/dart"></script>
<script Xsrc="packages/browser/dart.js"></script>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xsrc ?

@vicb
Copy link
Contributor

vicb commented Aug 14, 2014

Could WTF be Stats (more generic) ?
WTF would be one of the reporter than can be added to Stats, Observatory would be an other one.

@jbdeboer
Copy link
Contributor

Code changes need tests.

Echoing @vicb, a design discussion would be useful as it is not clear why we are referencing a specific tracing framework throughout the Angular code base instead of using the existing perf_api or a more generic approach.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

4 participants