Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Must bump perf_api to 0.0.9 to fix checked mode in dart 1.6 #1407

Closed
lassedamgaard opened this issue Aug 29, 2014 · 5 comments
Closed

Must bump perf_api to 0.0.9 to fix checked mode in dart 1.6 #1407

lassedamgaard opened this issue Aug 29, 2014 · 5 comments

Comments

@lassedamgaard
Copy link

perf_api 0.0.8 contains an invalid const constructor which the type checker ignored in dart 1.5.8 but throws on in 1.6. Using 0.0.9 fixes this. See google/perf_api.dart@3f0ae97

Error in dart 1.6 using 0.0.8:

Internal error: 'http://localhost:2000/main.dart': error: line 151 pos 17: expression is not a valid compile-time constant
    final Map<String, int> _counters = <String, int>{};
@zoechi
Copy link
Contributor

zoechi commented Aug 29, 2014

seems to be a dup of dart-archive/angular.dart.tutorial#128, #1350

@lassedamgaard
Copy link
Author

Hmm.. the fix for that seems completely unrelated though: https://github.com/angular/angular.dart/pull/1353/files
This is described as a workaround for a path resolution bug in dart. I don't think the check on const constructors is a bug.

@vicb
Copy link
Contributor

vicb commented Aug 29, 2014

@lassedamgaard seems a valid concern.

However we depend on '>=0.0.8 <0.1.0' then the latest release (0.0.9) should be installed. Do you have some other package that depends on '<0.0.9' ?

I'll fix our req but I'd like to understand how you got 0.0.8 installed, ie if other pkgs need tp be updated

vicb added a commit to vicb/angular.dart that referenced this issue Aug 29, 2014
fixes dart-archive#1407

perf_api 0.0.8 contains an invalid const constructor which the type
checker ignored in dart 1.5.8 but throws on in 1.6. Using 0.0.9 fixes
this.
@lassedamgaard
Copy link
Author

@vicb I don't have other components that depend on perf_api but am using pubspec.lock and don't upgrade dependencies that often. So it was simply the case that my lockfile was created when only perf_api 0.0.8 was available and I hadn't upgraded it since.
Anyway, I'm just saying that since perf_api 0.0.8 isn't compatible with dart 1.6 the angular pubspec constraint should not include it.

@vicb
Copy link
Contributor

vicb commented Aug 29, 2014

@lassedamgaard I agree with you, I only wanted to check if other packages need to be updated. The PR has been submitted (the lock file is master is alright, only pubspec.yamlhas been updated).
Thanks for your report.

@vicb vicb closed this as completed in 09d3c83 Aug 29, 2014
vicb added a commit that referenced this issue Aug 29, 2014
fixes #1407

perf_api 0.0.8 contains an invalid const constructor which the type
checker ignored in dart 1.5.8 but throws on in 1.6. Using 0.0.9 fixes
this.

Closes #1408
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants