Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

Perf: The change detection AST for Scope.watch should be pre-computed #1086

Closed
jbdeboer opened this issue May 30, 2014 · 1 comment
Closed

Perf: The change detection AST for Scope.watch should be pre-computed #1086

jbdeboer opened this issue May 30, 2014 · 1 comment
Assignees
@jbdeboer
Labels
type: perf

Comments

@jbdeboer
Copy link
Contributor

Creating this AST is a major bottleneck for directive creation.
@jbdeboer jbdeboer self-assigned this May 30, 2014
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
5c8d03e 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
bf038b1 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
c68933d 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
320fc02 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
9ee888e 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
3ec2379 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch ASTs for bindings
70c6340 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 30, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch ASTs for bindings
5799927 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
03df7d0 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
a2c3bc1 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
c04860f 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
f6885af 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
8ed5c0f 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
22851c4 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch ASTs for bindings
9e09970 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
5b0fd4a 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
dab5d70 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
d8d429e 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
28f7c30 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
573eb28 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
4fcbc3c 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch ASTs for bindings
e26e9c2 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
e849ad9 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
9bf25bc 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
f39e7d9 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
9ce430d 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
f5bb843 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
50efc6c 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch ASTs for bindings
3b943ac 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
5211562 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
47d43b8 
For dart-archive#1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
6051340 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For #1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
1eedf01 
For #1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
bb3d79c 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For #1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
ecd75ce 
For #1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
daf8d5a 
For #1086
jbdeboer added a commit that referenced this issue Jun 5, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
90df4eb 
For #1086
Closes #1088
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
08070bb 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
4fa7a44 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
c84eff0 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
922e20f 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
25afc76 
For dart-archive#1086
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 5, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
c012b14 
For dart-archive#1086
@naomiblack naomiblack changed the title The change detection AST for Scope.watch should be pre-computed Perf: The change detection AST for Scope.watch should be pre-computed Jun 6, 2014
@jbdeboer
Copy link
Contributor Author

jbdeboer commented Jun 8, 2014

Closed, new work is done in #1110

@jbdeboer jbdeboer closed this as completed Jun 8, 2014
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
b557668 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
c17ff4d 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
b3a7779 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
4caf47a 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
dc8ff9a 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
8f53d9c 
For dart-archive#1086
Closes dart-archive#1088
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(element binder): Use a child scope instead of Scope.watch(contex…
4942845 
…t:o)

This is the only place where Scope.watch(context:o) is used and it is
in the way of optimizations.

For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
refactor(Scope): Pull ASTParser out of Scope into it's own library
1cb8535 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
chore(ASTParser): Clean up and refactor the ASTParser
7d224ba 
-> Make it injectable
-> Remove try/catch statements are extra state
-> Rename AstParser -> ASTParser
-> Rename ExpressionVisitor -> _ExpressionVisitor

For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(scope): Expose Scope.watchAST as a public API
acb3a16 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(compiler): Precompute Scope.watch AST for TextMustache
b7a3f1a 
For dart-archive#1086
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
feat(compiler): Pre-compile Scope.watch ASTs for attribute mustaches
7d80aed 
For dart-archive#1086
Closes dart-archive#1088
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jbdeboer jbdeboer

Labels
type: perf
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbdeboer