fix(scope): fix null comparisons

Closes #646
dart-archive · Mar 7, 2014 · fb0fe0e · fb0fe0e
1 parent d6bc9ab
commit fb0fe0e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/core/scope.dart b/lib/core/scope.dart
@@ -959,8 +959,8 @@ _operation_multiply(left, right)               => (left == null || right == null
 _operation_divide(left, right)                 => (left == null || right == null) ? null : left / right;
 _operation_divide_int(left, right)             => (left == null || right == null) ? null : left ~/ right;
 _operation_remainder(left, right)              => (left == null || right == null) ? null : left % right;
-_operation_equals(left, right)                 => (left == null || right == null) ? null : left == right;
-_operation_not_equals(left, right)             => (left == null || right == null) ? null : left != right;
+_operation_equals(left, right)                 => left == right;
+_operation_not_equals(left, right)             => left != right;
 _operation_less_then(left, right)              => (left == null || right == null) ? null : left < right;
 _operation_greater_then(left, right)           => (left == null || right == null) ? null : left > right;
 _operation_less_or_equals_then(left, right)    => (left == null || right == null) ? null : left <= right;

diff --git a/test/core/scope_spec.dart b/test/core/scope_spec.dart
@@ -87,8 +87,10 @@ void main() {
             ..watch('3 - null', r)
             ..watch('null + null', r)
             ..watch('null - null', r)
+            ..watch('null == null', r)
+            ..watch('null != null', r)
             ..digest();
-        expect(logger).toEqual([null, null, 6, 5, -4, 3, 0, 0]);
+        expect(logger).toEqual([null, null, 6, 5, -4, 3, 0, 0, true, false]);
       }));
 
       it('should invoke closures', inject((Logger logger, Map context, RootScope rootScope) {