fix(NgComponent): Handle errors while loading CSS

Closes #411
dart-archive · Feb 6, 2014 · b5aa130 · b5aa130
1 parent 2645fa9
commit b5aa130
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/core_dom/block_factory.dart b/lib/core_dom/block_factory.dart
@@ -311,7 +311,9 @@ class _ComponentFactory {
     List<async.Future<String>> cssFutures = new List();
     var cssUrls = component.cssUrls;
     if (cssUrls.isNotEmpty) {
-      cssUrls.forEach((css) => cssFutures.add( $http.getString(css, cache: $templateCache) ) );
+      cssUrls.forEach((css) => cssFutures.add(
+          $http.getString(css, cache: $templateCache).catchError((e) => '/*\n$e\n*/\n')
+      ) );
     } else {
       cssFutures.add( new async.Future.value(null) );
     }

diff --git a/test/core/templateurl_spec.dart b/test/core/templateurl_spec.dart
@@ -157,6 +157,22 @@ main() => describe('template url', () {
       expect(renderedText(element)).toEqual('.hello{}inline!');
     })));
 
+    it('should ignore CSS load errors ', async(inject((Http $http,
+           Compiler $compile, Scope $rootScope, Injector injector,
+           MockHttpBackend backend, DirectiveMap directives) {
+      var element = $('<div><inline-with-css log>ignore</inline-with-css><div>');
+      backend.expectGET('simple.css').respond(500, 'some error');
+      $compile(element, directives)(injector, element);
+
+      backend.flush();
+      microLeap();
+      expect(renderedText(element)).toEqual(
+          '/*\n'
+          'HTTP 500: some error\n'
+          '*/\n'
+          'inline!');
+    })));
+
     it('should load a CSS with no template', async(inject((Http $http,
           Compiler $compile, Scope $rootScope, Injector injector,
           MockHttpBackend backend, DirectiveMap directives) {