fix(redis/go-redis): return error if no addresses given

go-redis/go-redis.go

@@ -32,7 +32,6 @@ type Redis struct {
 // Factory function create new Redis instance.
 func Factory(redisConfiguration core.CacheProvider, logger core.Logger, stale time.Duration) (core.Storer, error) {
 	var options redis.UniversalOptions
-	options.ClientName = "souin-redis"
 
 	var hashtags string
 
@@ -74,6 +73,14 @@ func Factory(redisConfiguration core.CacheProvider, logger core.Logger, stale ti
 		}
 	}
 
+	if len(options.Addrs) == 0 {
+		return nil, errors.New("no redis addresses given.")
+	}
+
+	if options.ClientName == "" {
+		options.ClientName = "souin-redis"
+	}
+
 	cli := redis.NewUniversalClient(&options)
 
 	return &Redis{

redis/caddy/redis.go

@@ -33,8 +33,8 @@ func (Redis) CaddyModule() caddy.ModuleInfo {
 // Provision to do the provisioning part.
 func (b *Redis) Provision(ctx caddy.Context) error {
 	logger := ctx.Logger(b)
-	storer, err := redis.Factory(b.Configuration.Provider, logger.Sugar(), b.Configuration.Stale)
 
+	storer, err := redis.Factory(b.Configuration.Provider, logger.Sugar(), b.Configuration.Stale)
 	if err != nil {
 		return err
 	}

redis/redis.go

@@ -61,6 +61,10 @@ func Factory(redisConfiguration core.CacheProvider, logger core.Logger, stale ti
 		options.Dialer.Timeout = time.Second
 	}
 
+	if len(options.InitAddress) == 0 {
+		return nil, errors.New("no redis addresses given.")
+	}
+
 	cli, err := redis.NewClient(options)
 	if err != nil {
 		return nil, err