Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(configuration): extends with allowed_addional_status_code #577

Merged
merged 3 commits into from
Nov 21, 2024
+406 −140
Merged

feat(configuration): extends with allowed_addional_status_code #577

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeb3b00
feat(configuration): extends with allowed_addional_status_code
darkweak Nov 14, 2024
dec0714
fix(status-code-extension): allow empty responses to be cached
darkweak Nov 15, 2024
7fe5f43
fix(typo): allowed_additional_status_codes
darkweak Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
fix(status-code-extension): allow empty responses to be cached
@darkweak
darkweak committed Nov 15, 2024
commit dec0714c1cf2bc36929ecea6c87b97c26a9bd594
2 changes: 1 addition & 1 deletion pkg/middleware/middleware.go
View file
Original file line number Diff line number Diff line change
@@ -333,7 +333,7 @@ func (s *SouinBaseHandler) Store(
}
res.Header.Set(rfc.StoredLengthHeader, res.Header.Get("Content-Length"))
response, err := httputil.DumpResponse(&res, true)
if err == nil && (bLen > 0 || canStatusCodeEmptyContent(statusCode)) {
if err == nil && (bLen > 0 || canStatusCodeEmptyContent(statusCode) || s.hasAllowedAdditionalStatusCodesToCache(statusCode)) {
variedHeaders, isVaryStar := rfc.VariedHeaderAllCommaSepValues(res.Header)
if isVaryStar {
// "Implies that the response is uncacheable"