-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge with surrogate key not working #583
Comments
This probably isn't the "right" way to fix it but this is what we did inside pico (we are using our own impl of the souin API): https://github.com/picosh/pico/blob/706b21492f4133c7e5519a0a82f9d8c89fed8317/pgs/web.go#L315 |
Hey @neurosnap sorry for the long delay. I'll try to write a fix for that. |
darkweak
added a commit
that referenced
this issue
Dec 23, 2024
@neurosnap you can try the fix using
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Greetings, purging with surrogate keys is not currently working for me. It looks like the key values are getting stored URL encoded and then being sent to the
Storer
as-is and then not finding the keys to clear:https://github.com/darkweak/souin/blob/master/pkg/surrogate/providers/common.go#L223
It looks like we might need to expand the QueryUnescape logic? https://github.com/darkweak/souin/blob/master/pkg/surrogate/providers/common.go#L85
The text was updated successfully, but these errors were encountered: