Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panasonic DC-G9 high-res RAW: insufficient crop #170

Closed
hoedur opened this issue Feb 18, 2019 · 8 comments · Fixed by #490
Closed

Panasonic DC-G9 high-res RAW: insufficient crop #170

hoedur opened this issue Feb 18, 2019 · 8 comments · Fixed by #490

Comments

@hoedur
Copy link

hoedur commented Feb 18, 2019

When opening a High Resolution RAW (the large variant with ~125 MB file size) with darktable 2.6.0, artifacts can be seen on the right border of the picture (panorama) or on the top border (portrait).

This issue was approved by @LebedevRI. More details are to follow if needed.

@LebedevRI LebedevRI changed the title Probably high resolution RAW decoding issue with Panasonic DC-G9 (Firmware 1.2) Panasonic DC-G9 high-res RAW: insufficient crop Feb 18, 2019
@hoedur
Copy link
Author

hoedur commented Feb 18, 2019

Workaround: use the crop editing feature of the "raw black/white point" module:

  1. Edit "~/.config/darktable/darktablerc"
  2. Find the line "plugins/darkroom/rawprepare/allow_editing_crop=false"
  3. Change "false" to "true"
  4. Open darktable and go to the "RAW black/white point" module
  5. There should be a slider "crop width"; increase this value until the artifacts are gone
  6. If you don't see this slider, then you might first delete "~/.config/darktable/" (create a backup first, as this fries your settings!)

@kmilos
Copy link
Collaborator

kmilos commented Apr 11, 2023

Yep, both the single 20MP shot out of the hi-res sequence, and the hi-res output as well seem to need extra 16px cropped.

The single shot has width of 5280 instead of the 5264 found in the normal mode.

More bizarrely, there is also this burst mode (sample also in RPU), where the width stayed the same as normal, but the height went up by 8 pixels (look like both top and bottom)!

@jsmucr
Copy link
Contributor

jsmucr commented Apr 11, 2023

Would it help if I provided raws in various different modes?

@kmilos
Copy link
Collaborator

kmilos commented Apr 11, 2023

Would it help if I provided raws in various different modes?

They're all on RPU already AFAICT.

@kofa73
Copy link

kofa73 commented Apr 11, 2023

Is this related to High-Res mode? My LX7, which has no such feature, is affected by a similar issue. @kmilos is aware of the bug report I've opened for darktable, but maybe it's worth linking here:
darktable-org/darktable#14082

@jdneumeyer77
Copy link
Contributor

jdneumeyer77 commented Apr 21, 2023

This appears to be affecting the Panasonic S5 high-res raw files as well, but not the normal raw files. It was working fine, but I haven't kept up since my PR was merged for v7 Panasonic raw format a couple months ago. Now I'm getting pink garbage on the right side of hi-res as well. I haven't had time to investigate more, but it looks similar to darktable-org/darktable#14082.

@jsmucr
Copy link
Contributor

jsmucr commented Jun 28, 2023

@kofa73 @jdneumeyer77 Yes, it's all the same thing. I'm working on a fix for the G9 static cases such as hi-res or burst modes, but that won't help with all the issues.

@jsmucr
Copy link
Contributor

jsmucr commented Jun 28, 2023

I've analyzed a collection of my G9 photos from May, and there's apparently no point in trying to fix it by adding more modes.
https://discuss.pixls.us/t/panasonic-g9-rawspeed-and-cropping/38236/5?u=newerth

The entire approach will need to change.

jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 29, 2023
WIP

This is supposed to fix darktable-org#170 and help prepare other related fixes.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 29, 2023
WIP

This is supposed to fix darktable-org#170 and help prepare other related fixes.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 29, 2023
WIP

This is supposed to fix darktable-org#170 and help prepare other related fixes.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 29, 2023
WIP

This is supposed to fix darktable-org#170 and help prepare other related fixes.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 29, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 30, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 30, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 30, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jun 30, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jul 1, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
jsmucr added a commit to jsmucr/rawspeed that referenced this issue Jul 1, 2023
This is supposed to fix darktable-org#170 and help prepare other related fixes.

Now the decoders can decide whether to supply their own crop data when the Crop
tag in a camera.xml entry is empty or absent. Rw2Decoder has been updated to
leverage this new ability, and the Crop tags for Panasonic G9 entries have been
removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants