Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): prevent errors when vars.CODECOV_BRANCHES is undefined (espe… #67

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

JRocabruna
Copy link
Member

Description

This pull request addresses an issue where the CI pipeline would fail if the environment variable vars.CODECOV_BRANCHES is not set. This situation commonly occurs when the code is being built from a forked repository. By adding a check for the existence of this variable, we ensure that the CI process can proceed smoothly without interruption.

  • Related Issue: Closes #[issue_number]
  • Type of Change:
    • Bug fix (non-breaking change which fixes an issue)

Checklist

Please ensure the following guidelines are met:

  • The code follows the style guidelines of this project.
  • A self-review has been performed on the code.
  • The code is well-documented, and comments have been added where necessary.
  • Tests have been added to prove that the fix is effective or that the feature works. All existing tests pass.
  • Commit messages follow the convention type(scope): description.
  • The pull request has no conflicts with the base branch.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

This fix is essential for ensuring the stability of the CI pipeline when handling forks, which do not always have the same environment variables set as the original repository. No additional dependencies are required for this change.

…cially from forks)

This commit addresses an issue where the CI pipeline would fail if the environment variable vars.CODECOV_BRANCHES is not set. This situation commonly occurs when the code is being built from a forked repository. By adding a check for the existence of this variable, we ensure that the CI process can proceed smoothly without interruption.
@JRocabruna JRocabruna self-assigned this Jul 18, 2024
Copy link
Collaborator

@DarkRockMountain-admin DarkRockMountain-admin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments

The optimization of the CI workflow is a welcome improvement, enhancing the efficiency and reliability of the build process.

Review Checklist

  • Code adheres to the project's coding guidelines.
  • Changes are well-documented.
  • Tests have been added/updated and pass successfully.
  • Commit messages follow the correct format: type(scope): description.
  • No conflicts with the base branch.

Approval

Approved: Changes look good and meet the project's contribution standards.

@DarkRockMountain-admin DarkRockMountain-admin merged commit 252a782 into develop Jul 18, 2024
7 checks passed
@DarkRockMountain-admin DarkRockMountain-admin deleted the feature/workflow-update branch July 18, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants