Mock callbacks #707
Merged
Mock callbacks #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite operations via callbacks
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMock.java # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleDeviceMock.java
1 failing, not sure why…
|
This is now complete and is just waiting for other PRs to be approved. |
# Conflicts: # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMock.java
# Conflicts: # mockrxandroidble/README.md # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMock.java # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleConnectionMock.java # mockrxandroidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleDeviceMock.java # mockrxandroidble/src/test/groovy/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMockTest.groovy
|
Again merged |
...androidble/src/main/java/com/polidea/rxandroidble2/mockrxandroidble/RxBleConnectionMock.java
Outdated
Show resolved
Hide resolved
I wanted to override the method in the base interface to rename a parameter. Looks like this can’t be done, so I just removed the base interfaces.
dariuszseweryn
requested changes
Aug 12, 2020
...a/com/polidea/rxandroidble2/mockrxandroidble/Callbacks/Results/RxBleGattWriteResultMock.java
Outdated
Show resolved
Hide resolved
...oidble/src/test/groovy/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMockTest.groovy
Outdated
Show resolved
Hide resolved
...oidble/src/test/groovy/com/polidea/rxandroidble2/mockrxandroidble/RxBleClientMockTest.groovy
Outdated
Show resolved
Hide resolved
dariuszseweryn
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on PR #706 and enhances the functionality provided by
RxBleConnectionMockto allow the user to provide callbacks to handle characteristic and descriptor read and write.Tests added, however one is failing and it's a bit too late on a Friday for my frazzled brain to figure out! Help would be appreciated.
I also need to update the readme. Otherwise complete.