-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gateway): try multiple gateways when searching #8
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. I did leave a couple of comments and could you also do the same for async-std impl of aio?
Thanks for reviewing! OK, I will do the same for async-std. |
@dariusc93 async-std changes have been implemented as well now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the late review.
@jxs do you have any other suggestions or comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Sorry for the late review.
@jxs do you have any other suggestions or comments?
no no, LGTM! Thanks for the ping Darius
Released under 0.15.0 |
In the case that a network contains multiple UPnP devices that respond to the search gateway signal; Try them all until one of them is considered valid.