Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateway): try multiple gateways when searching #8

Merged
merged 4 commits into from
Sep 4, 2024

Conversation

mickvandijke
Copy link

In the case that a network contains multiple UPnP devices that respond to the search gateway signal; Try them all until one of them is considered valid.

Copy link
Owner

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I did leave a couple of comments and could you also do the same for async-std impl of aio?

src/aio/tokio.rs Show resolved Hide resolved
src/aio/tokio.rs Outdated Show resolved Hide resolved
@mickvandijke
Copy link
Author

Thank you for the PR. I did leave a couple of comments and could you also do the same for async-std impl of aio?

Thanks for reviewing! OK, I will do the same for async-std.

@mickvandijke
Copy link
Author

mickvandijke commented Aug 2, 2024

@dariusc93 async-std changes have been implemented as well now.

@mickvandijke mickvandijke requested review from dariusc93 and jxs August 16, 2024 07:49
Copy link
Owner

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the late review.

@jxs do you have any other suggestions or comments?

Copy link

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the late review.

@jxs do you have any other suggestions or comments?

no no, LGTM! Thanks for the ping Darius

@dariusc93 dariusc93 merged commit 56934bb into dariusc93:master Sep 4, 2024
@dariusc93
Copy link
Owner

Released under 0.15.0

CC @mickvandijke @jxs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants