Don't calculate unnecessary contrast ratios

darekkay · Nov 23, 2020 · 896d22f · 896d22f
1 parent 36fb0ae
commit 896d22f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## [Unreleased]
 
 - :rocket: Ignore invalid colors.
+- :rocket: Don't calculate unnecessary contrast ratios.
 - :hammer: Replace TravisCI with GitHub Actions.
 
 ## [1.1.0] - 2020-10-28

diff --git a/src/index.js b/src/index.js
@@ -23,12 +23,12 @@ const verifyContrastRatio = (palette, magicNumber) => {
 
   palette.forEach((color1) => {
     palette.forEach((color2) => {
-      const contrastRatio = color1.onecolorValue.contrast(color2.onecolorValue);
-
       if (color1.grade > color2.grade) {
         return; // don't compare same colors to each other
       }
 
+      const contrastRatio = color1.onecolorValue.contrast(color2.onecolorValue);
+
       if (Math.abs(color1.grade - color2.grade) >= magicNumber.value) {
         if (contrastRatio < magicNumber.ratio) {
           violations.push({ color1, color2, contrastRatio });