Ignore invalid colors

Fixes: #2

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [Unreleased]
 
+- :rocket: Ignore invalid colors.
 - :hammer: Replace TravisCI with GitHub Actions.
 
 ## [1.1.0] - 2020-10-28

src/__tests__/index.js

@@ -1,3 +1,4 @@
+const onecolor = require("onecolor");
 const { isFlat, flattenPalette, normalizePalette } = require("../index");
 
 const flatPalette = {
@@ -27,13 +28,13 @@ const nestedPalette = {
 };
 
 const normalizedPalette = [
-  { family: "light-blue", grade: 10, hex: "#d9e8f6" },
-  { family: "light-blue", grade: 20, hex: "#aacdec" },
-  { family: "green", grade: 10, hex: "#dfeacd" },
-  { family: "green", grade: 20, hex: "#b8d293" },
-  { family: "white", grade: 0, hex: "#ffffff" },
-  { family: "black", grade: 100, hex: "#000000" },
-];
+  { family: "light-blue", grade: 10, value: "#d9e8f6" },
+  { family: "light-blue", grade: 20, value: "#aacdec" },
+  { family: "green", grade: 10, value: "#dfeacd" },
+  { family: "green", grade: 20, value: "#b8d293" },
+  { family: "white", grade: 0, value: "#ffffff" },
+  { family: "black", grade: 100, value: "#000000" },
+].map((color) => ({ ...color, onecolorValue: onecolor(color.value) }));
 
 test("isFlat returns true for flat color palette definition", () => {
   expect(isFlat(flatPalette)).toBe(true);

src/index.js

@@ -23,7 +23,7 @@ const verifyContrastRatio = (palette, magicNumber) => {
 
   palette.forEach((color1) => {
     palette.forEach((color2) => {
-      const contrastRatio = onecolor(color1.hex).contrast(onecolor(color2.hex));
+      const contrastRatio = color1.onecolorValue.contrast(color2.onecolorValue);
 
       if (color1.grade > color2.grade) {
         return; // don't compare same colors to each other
@@ -68,28 +68,41 @@ const flattenPalette = (nestedPalette) =>
     {}
   );
 
-/** Create an array of { family, grade, hex } values */
+/** Create an array of { family, grade, value } values */
 const normalizePalette = (flatPalette) =>
   Object.entries(flatPalette).reduce(
-    (accumulator2, [name, hex]) => [
+    (accumulator2, [name, value]) => [
       ...accumulator2,
       {
         family: name.substring(0, name.lastIndexOf("-")),
         grade: parseInt(name.substring(name.lastIndexOf("-") + 1), 10),
-        hex,
+        value,
+        onecolorValue: onecolor(value.trim()),
       },
     ],
     []
   );
 
+const removeInvalidColors = (palette) => {
+  return palette.filter((color) => {
+    if (!color.onecolorValue) {
+      logger.error(
+        `Color ${color.family}-${color.grade} is invalid: '${color.value}'`
+      );
+    }
+    return !!color.onecolorValue;
+  });
+};
+
 const run = (colors, config) => {
   logger.info(`${green("Analyzing")}: ${config.file}`);
 
   const flatPalette = isFlat(colors) ? colors : flattenPalette(colors);
   const normalizedPalette = normalizePalette(flatPalette);
-  const magicNumbers = calculateMagicNumbers(normalizedPalette);
+  const validPalette = removeInvalidColors(normalizedPalette);
+  const magicNumbers = calculateMagicNumbers(validPalette);
 
-  logger.log(`${green("Colors:")} ${normalizedPalette.length}`);
+  logger.log(`${green("Colors:")} ${validPalette.length}`);
   logger.log(green("Magic numbers:"));
   Object.entries(magicNumbers).forEach(([grade, magicNumber]) => {
     logger.log(