Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for external sub clusters. #211

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

tmacam
Copy link
Contributor

@tmacam tmacam commented Nov 1, 2023

This commit updates the workflows to use the clusters configured
in the OSS subscription. Those clusters were created as documented
in #167.

Those clusters live in distinct subscription and have distinct names
from the current ones -- hence the need to update the workflows.

Additionally, because those clusters use Bicep-configure Azure-hosted
state store, binding and pubsub components, there is no need to
configure Redis, Kafka or setup individual components.

Signed-off-by: Tiago Alves Macambira [email protected]

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@tmacam tmacam marked this pull request as ready for review November 2, 2023 00:10
This commit updates the workflows to use the clusters configured
in the OSS subscription. Those clusters were created as documented
in dapr#167.

Those clusters live in distinct subscription and have distinct names
as the current ones -- hence the need to update the workflows.

Additionally, because those clusters use Bicep-configure Azure-hosted
state store, binding and pubsub components, there is no need to
configure Redis, Kafka or setup individual components.

Signed-off-by: Tiago Alves Macambira <[email protected]>
@tmacam tmacam force-pushed the UpdateWorkflowsForExternSubClusters branch from be5e582 to 629cba8 Compare November 2, 2023 17:34
Copy link
Contributor

@philliphoff philliphoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmacam tmacam assigned tmacam and berndverst and unassigned tmacam Nov 2, 2023
@berndverst berndverst merged commit 679cfc0 into dapr:master Nov 6, 2023
1 check passed
@tmacam tmacam deleted the UpdateWorkflowsForExternSubClusters branch November 7, 2023 00:56
@tmacam tmacam mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants