Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pub-Sub C# - HTTP README.md #934

Closed
wants to merge 1 commit into from
Closed

Conversation

srparupu
Copy link

@srparupu srparupu commented Sep 22, 2023

Changing the port number from 7005 to 7006 based on the port mentioned in pub_sub/csharp/sdk/order-processor/properties/launchSetting.json

Description

Changed the port number from 7005 to 7006 based on the port mentioned in pub_sub/csharp/sdk/order-processor/properties/launchSetting.json

Issue reference

#913

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Changing the port number from 7005  to 7006 based on the port mentioned in pub_sub/csharp/sdk/order-processor/properties/launchSetting.json

Signed-off-by: srparupu <[email protected]>
@srparupu srparupu changed the title Update README.md Update Pub-Sub C# - HTTP README.md Sep 22, 2023
Copy link

@dasanind dasanind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@paulyuk paulyuk added this to the 1.12 milestone Oct 6, 2023
@paulyuk
Copy link
Contributor

paulyuk commented Oct 6, 2023

Thanks a bunch @srparupu. We had the same fix in the release-1.12 branch as a part of the multi app run work. This was the right fix
088b5f6

Let me see about getting you credit in release notes. Thanks again.

@srparupu
Copy link
Author

srparupu commented Oct 6, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants