Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments with correct port #900

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Update comments with correct port #900

merged 1 commit into from
Sep 8, 2023

Conversation

hughxia
Copy link
Contributor

@hughxia hughxia commented Aug 26, 2023

Description

Update the commonts with correct port

Issue reference

Please reference the issue this PR will close: #899

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Copy link
Contributor

@rabollin rabollin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the change and fixing comment is good enough. dapr.yml & the actual code is correctly referencing the app port as 6006.

Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit a9a48ec into dapr:master Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang service_invocation/order-processor has an incorrect port
3 participants