-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate_tutorials #1069
fix: validate_tutorials #1069
Conversation
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
9482dcb
to
231fb83
Compare
Signed-off-by: mikeee <[email protected]>
Signed-off-by: mikeee <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thank you for fixing tutorials!! this has been a long road.
KIND_VERSION: v0.12.0 | ||
KIND_IMAGE_SHA: sha256:69860bda5563ac81e3c0057d654b5253219618a22ec3a346306239bba8cfa1a6 | ||
GOVER: 1.22 | ||
KUBERNETES_VERSION: v1.29.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modern kubernetes and kind versions. check!
@@ -389,6 +389,8 @@ expected_stdout_lines: | |||
- '"total":"54"' | |||
output_match_mode: substring | |||
name: "Curl test" | |||
background: false | |||
sleep: 5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this makes more resilient for timing issues in the runner
Description
validate_tutorials.yaml
Issue reference
CLI related issue: 1436
We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: