Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Holopin alias field #706

Merged
merged 1 commit into from
May 2, 2024
Merged

Fix Holopin alias field #706

merged 1 commit into from
May 2, 2024

Conversation

marcduiker
Copy link
Contributor

@marcduiker marcduiker commented May 2, 2024

Description

The alias field of the Holopin.yml file was incorrect. This PR fixes this.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #693

Signed-off-by: Marc Duiker <[email protected]>
@marcduiker marcduiker requested review from a team as code owners May 2, 2024 13:33
@berndverst berndverst merged commit 3f9da2c into dapr:main May 2, 2024
16 checks passed
ksachdeva pushed a commit to ksachdeva/dapr-python-sdk that referenced this pull request Jun 24, 2024
Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>
berndverst added a commit that referenced this pull request Jun 26, 2024
…Runtime & ext/fastapi,flask (#714)

* Fix Holopin alias (#706)

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>

* Add the support to pass user supplied actor_factory callable in ActorRuntime & ext/fastapi,flask

Signed-off-by: Kapil Sachdeva <[email protected]>

* chore - lint runtime.py & test_actor_factory.py

Signed-off-by: Kapil Sachdeva <[email protected]>

* Pin workflow SDK 0.4.1 in example (#715)

* Pin workflow SDK 0.4.1 in example

Signed-off-by: Bernd Verst <[email protected]>

* fix workflow dev version

Signed-off-by: Bernd Verst <[email protected]>

* fix workflow example dependency

Signed-off-by: Bernd Verst <[email protected]>

---------

Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>

* doc: document that users can self-assign issues (#712)

* doc: document that users can self-assign issues

Signed-off-by: KentHsu <[email protected]>

* doc: reorder paragraph and update CONTRIBUTING.md

Signed-off-by: KentHsu <[email protected]>

---------

Signed-off-by: KentHsu <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>

* Standardize README shield badges (#721)

Signed-off-by: Pieter de Bruin <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>

* remove unneeded import

Signed-off-by: Bernd Verst <[email protected]>

---------

Signed-off-by: Marc Duiker <[email protected]>
Signed-off-by: Kapil Sachdeva <[email protected]>
Signed-off-by: Bernd Verst <[email protected]>
Signed-off-by: KentHsu <[email protected]>
Signed-off-by: Pieter de Bruin <[email protected]>
Co-authored-by: Marc Duiker <[email protected]>
Co-authored-by: Bernd Verst <[email protected]>
Co-authored-by: Kent (Chia-Hao), Hsu <[email protected]>
Co-authored-by: Elena Kolevska <[email protected]>
Co-authored-by: Pieter de Bruin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the holopin.yaml to use the sdk badge
2 participants