Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Metrics Path Matching #58

Merged
merged 8 commits into from
May 29, 2024

Conversation

nelson-parente
Copy link
Contributor

@nelson-parente nelson-parente commented May 17, 2024

This proposal introduces a new opt-in API for path matching in Dapr HTTP metrics, allowing users to define specific paths to manage cardinality, improve observability, and maintain performance without relying on regexes.

Signed-off-by: nelson.parente <[email protected]>
@nelson-parente nelson-parente force-pushed the feat/http-path-normalizatoin branch from 7c3ab40 to f1ebc8c Compare May 17, 2024 18:27
@nelson-parente nelson-parente changed the title feat: initial version [WIP] HTTP Metrics Path Normalization May 20, 2024
@nelson-parente nelson-parente marked this pull request as ready for review May 20, 2024 17:29
Signed-off-by: nelson.parente <[email protected]>
@nelson-parente nelson-parente changed the title [WIP] HTTP Metrics Path Normalization HTTP Metrics Path Normalization May 20, 2024
20240517-R-http-metrics-path-normalization.md Outdated Show resolved Hide resolved
20240517-R-http-metrics-path-normalization.md Outdated Show resolved Hide resolved
20240517-R-http-metrics-path-normalization.md Outdated Show resolved Hide resolved
20240517-R-http-metrics-path-normalization.md Outdated Show resolved Hide resolved
Signed-off-by: nelson.parente <[email protected]>
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some other comments that I think is important.

Signed-off-by: nelson.parente <[email protected]>
@nelson-parente nelson-parente changed the title HTTP Metrics Path Normalization HTTP Metrics Path Matching May 28, 2024
@yaron2
Copy link
Member

yaron2 commented May 28, 2024

+1 binding

1 similar comment
@artursouza
Copy link
Member

+1 binding

@mikeee mikeee mentioned this pull request May 28, 2024
43 tasks
@daixiang0
Copy link
Member

+1 binding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants