-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP Metrics Path Matching #58
Merged
yaron2
merged 8 commits into
dapr:main
from
nelson-parente:feat/http-path-normalizatoin
May 29, 2024
Merged
HTTP Metrics Path Matching #58
yaron2
merged 8 commits into
dapr:main
from
nelson-parente:feat/http-path-normalizatoin
May 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
force-pushed
the
feat/http-path-normalizatoin
branch
from
May 17, 2024 18:27
7c3ab40
to
f1ebc8c
Compare
nelson-parente
changed the title
feat: initial version
[WIP] HTTP Metrics Path Normalization
May 20, 2024
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
changed the title
[WIP] HTTP Metrics Path Normalization
HTTP Metrics Path Normalization
May 20, 2024
artursouza
reviewed
May 21, 2024
Signed-off-by: nelson.parente <[email protected]>
This was referenced May 21, 2024
Signed-off-by: nelson.parente <[email protected]>
JoshVanL
requested changes
May 24, 2024
Signed-off-by: nelson.parente <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
reviewed
May 25, 2024
artursouza
reviewed
May 25, 2024
artursouza
reviewed
May 25, 2024
artursouza
reviewed
May 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some other comments that I think is important.
Signed-off-by: nelson.parente <[email protected]>
nelson-parente
changed the title
HTTP Metrics Path Normalization
HTTP Metrics Path Matching
May 28, 2024
Signed-off-by: nelson.parente <[email protected]>
+1 binding |
1 similar comment
+1 binding |
artursouza
approved these changes
May 28, 2024
43 tasks
+1 binding |
daixiang0
approved these changes
May 29, 2024
7 tasks
This was referenced Jun 18, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal introduces a new opt-in API for path matching in Dapr HTTP metrics, allowing users to define specific paths to manage cardinality, improve observability, and maintain performance without relying on regexes.