Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC TLS endpoint to default to 80 for HTTP for backwards compat. #57

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Update gRPC TLS endpoint to default to 80 for HTTP for backwards compat. #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions 20230627-S-sidecar-endpoint-tls.md → 20240508-S-sidecar-endpoint-tls.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Dapr endpoint env and TLS support in SDKs

* Author(s): Artur Souza (@artursouza)
* Author(s): Artur Souza (@artursouza), Josh van Leeuwen (@JoshVanL)
* State: Ready for Implementation
* Updated: 06/27/2023
* Updated: 05/08/2024

## Overview

Expand Down Expand Up @@ -90,6 +90,8 @@ myhost:1003?tls=true => port=1003 tls=true resolver=dns
dns://myhost:1003?tls=true => port=1003 tls=true resolver=dns
unix://my.sock => port=<no concept of port> tls=false resolver=unix
unix://my.sock?tls=true => port=<no concept of port> tls=true resolver=unix
http://myhost => port=80 tls=false resolver=dns
https://myhost => port=443 tls=true resolver=dns
```

#### Example of implementation
Expand Down Expand Up @@ -150,7 +152,7 @@ What changes or actions are required to make this proposal complete?
| myhost:443 | dns:myhost:443 | myhost | 443 | FALSE | |
| myhost:443?tls=false | dns:myhost:443 | myhost | 443 | FALSE | |
| myhost:443?tls=true | dns:myhost:443 | myhost | 443 | TRUE | |
| [http://myhost](http://myhost) | dns:myhost:443 | myhost | 443 | FALSE | |
| [http://myhost](http://myhost) | dns:myhost:80 | myhost | 80 | FALSE | |
| [http://myhost?tls=false](http://myhost?tls=false) | | | | | the tls query parameter is not supported for http(s) endpoints: 'tls=false' |
| [http://myhost?tls=true](http://myhost?tls=true) | | | | | the tls query parameter is not supported for http(s) endpoints: 'tls=true' |
| [http://myhost:443](http://myhost:443) | dns:myhost:443 | myhost | 443 | FALSE | |
Expand Down Expand Up @@ -182,7 +184,7 @@ What changes or actions are required to make this proposal complete?
| dns:[2001:db8:1f70::999:de8:7648:6e8]:5000?abc=[] | | | | | Error: query parameters are not supported for gRPC endpoints: 'abc=[]' |
| dns://myauthority:53/[2001:db8:1f70::999:de8:7648:6e8] | dns://myauthority:53/[2001:db8:1f70::999:de8:7648:6e8]:443 | [2001:db8:1f70::999:de8:7648:6e8] | 443 | FALSE | |
| dns:[2001:db8:1f70::999:de8:7648:6e8] | dns:[2001:db8:1f70::999:de8:7648:6e8]:443 | [2001:db8:1f70::999:de8:7648:6e8] | 443 | FALSE | |
| https://[2001:db8:1f70::999:de8:7648:6e8] | dns:[2001:db8:1f70::999:de8:7648:6e8]:443 | [2001:db8:1f70::999:de8:7648:6e8] | 443 | TRUE | |
| https://[2001:db8:1f70::999:de8:7648:6e8] | dns:[2001:db8:1f70::999:de8:7648:6e8]:80 | [2001:db8:1f70::999:de8:7648:6e8] | 80 | TRUE | |
artursouza marked this conversation as resolved.
Show resolved Hide resolved
| https://[2001:db8:1f70::999:de8:7648:6e8]:5000 | dns:[2001:db8:1f70::999:de8:7648:6e8]:5000 | [2001:db8:1f70::999:de8:7648:6e8] | 5000 | TRUE | |
| host:5000/v1/dapr | | | | | paths are not supported for gRPC endpoints: '/v1/dapr' |
| host:5000/?a=1 | | | | | paths are not supported for gRPC endpoints: '/' |
Expand Down