-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix e2e test common/server/server.test.ts #555
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 6 6
Branches 1 1
=========================================
Hits 6 6 ☔ View full report in Codecov by Sentry. |
MregXN
force-pushed
the
fix-e2e-common-server-test
branch
3 times, most recently
from
November 28, 2023 15:01
84b0f3a
to
a00594c
Compare
MregXN
force-pushed
the
fix-e2e-common-server-test
branch
from
November 29, 2023 02:01
05194da
to
a00594c
Compare
MregXN
force-pushed
the
fix-e2e-common-server-test
branch
5 times, most recently
from
December 5, 2023 15:23
5bab6e8
to
c783ecf
Compare
MregXN
force-pushed
the
fix-e2e-common-server-test
branch
from
December 6, 2023 03:45
0cea6bd
to
afbd69a
Compare
Signed-off-by: MregXN <[email protected]>
MregXN
force-pushed
the
fix-e2e-common-server-test
branch
from
December 6, 2023 04:51
7dc2691
to
2c3c605
Compare
shubham1172
reviewed
Dec 6, 2023
Closed
shubham1172
reviewed
Dec 13, 2023
Co-authored-by: Shubham Sharma <[email protected]> Signed-off-by: MregXN <[email protected]>
shubham1172
approved these changes
Dec 13, 2023
Closing this PR to fix flakiness in tests for now, root cause still remains to be inspected and will be tracked by #560 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fails due to the following log. For more log details refer to this link.
The delay is not long enough to wait for the event to arrive. Adding more delay could be helpful.
Issue reference
Please refer to the the point 4 of issue #7128 in dapr/dapr.