Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e test common/server/server.test.ts #555

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Nov 28, 2023

Description

It fails due to the following log. For more log details refer to this link.

...
  ● common/server › pubsub › grpc/should mark messages as processed successfully (SUCCESS) by-default, and the same message should not be received anymore

    expect(received).toBe(expected) // Object.is equality

    Expected: 1
    Received: 0

      163 |         // Delay a bit for event to arrive
      164 |         await new Promise((resolve, _reject) => setTimeout(resolve, 1000));
    > 165 |         expect(mockSubscribeStatusHandler.mock.calls.length).toBe(1);
          |                                                              ^
      166 |         expect(mockSubscribeStatusHandler.mock.calls[0][1]).toEqual("SUCCESS");
      167 |         expect(mockSubscribeDeadletterHandler.mock.calls.length).toBe(0);
      168 |       },

      at test/e2e/common/server.test.ts:165:62
      at fulfilled (test/e2e/common/server.test.ts:17:58)
...

The delay is not long enough to wait for the event to arrive. Adding more delay could be helpful.

Issue reference

Please refer to the the point 4 of issue #7128 in dapr/dapr.

@MregXN MregXN requested review from a team as code owners November 28, 2023 13:24
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d33c5a4) 100.00% compared to head (76cd8b5) 100.00%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #555   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6         6           
  Branches         1         1           
=========================================
  Hits             6         6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MregXN MregXN marked this pull request as draft November 28, 2023 14:14
@MregXN MregXN force-pushed the fix-e2e-common-server-test branch 3 times, most recently from 84b0f3a to a00594c Compare November 28, 2023 15:01
@MregXN MregXN marked this pull request as ready for review November 28, 2023 15:08
@MregXN MregXN force-pushed the fix-e2e-common-server-test branch from 05194da to a00594c Compare November 29, 2023 02:01
@MregXN MregXN marked this pull request as draft November 29, 2023 02:14
@MregXN MregXN force-pushed the fix-e2e-common-server-test branch 5 times, most recently from 5bab6e8 to c783ecf Compare December 5, 2023 15:23
@MregXN MregXN marked this pull request as ready for review December 5, 2023 16:07
@MregXN MregXN marked this pull request as draft December 5, 2023 16:25
@MregXN MregXN force-pushed the fix-e2e-common-server-test branch from 0cea6bd to afbd69a Compare December 6, 2023 03:45
@MregXN MregXN force-pushed the fix-e2e-common-server-test branch from 7dc2691 to 2c3c605 Compare December 6, 2023 04:51
@MregXN MregXN marked this pull request as ready for review December 6, 2023 05:09
Co-authored-by: Shubham Sharma <[email protected]>
Signed-off-by: MregXN <[email protected]>
@shubham1172
Copy link
Member

Closing this PR to fix flakiness in tests for now, root cause still remains to be inspected and will be tracked by #560

@shubham1172 shubham1172 added this pull request to the merge queue Dec 13, 2023
Merged via the queue into dapr:main with commit 6e89215 Dec 13, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants