-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds docs for client initialisation with env variables #992
Conversation
Signed-off-by: Elena Kolevska <[email protected]>
@cicoyle could you please review this, I'm not very familiar with the java-sdk. Thanks 🙏 |
without any arguments: | ||
|
||
```bash | ||
export DAPR_GRPC_ENDPOINT="mydomain:50051?tls=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit: Initialising
-> Initializing
&& standardising
-> standardizing
. I'm not 100% confident I see the parsing for the tls=true
in our codebase. I might've just missed it though. Once this is confirmed, then I think the PR is good to go. Thank you for documenting this 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may be missing a conditional, like:
if (uri.getQuery() != null && uri.getQuery().contains("tls=true")) {
insecure = false;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cassie! I realised I had some copy/paste leftovers from the python-sdk. I fixed that now.
The ?tls
query parameter was added in this proposal.
I removed the example for now, so we're not showing the grpc endpoint with "https", and we can come back to this and add it, once the support for tls is added.
Signed-off-by: Elena Kolevska <[email protected]>
Signed-off-by: Elena Kolevska <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the docs 🎉
Co-authored-by: Cassie Coyle <[email protected]> Signed-off-by: Elena Kolevska <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #992 +/- ##
=========================================
Coverage 77.31% 77.31%
Complexity 1537 1537
=========================================
Files 143 143
Lines 4642 4642
Branches 541 541
=========================================
Hits 3589 3589
Misses 778 778
Partials 275 275 ☔ View full report in Codecov by Sentry. |
Description
Added a section in the docs on initialising the client and the supported environment variables
Issue reference
dapr/docs#3921
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
N/A