Show registered workflows and Activities #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addjuarez
force-pushed
the
workflowLogging
branch
from
759528a
to
bf060bc
Compare
artursouza
requested changes
Nov 13, 2023
sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilder.java
Outdated
Show resolved
Hide resolved
addjuarez
force-pushed
the
workflowLogging
branch
from
eb8bdae
to
0beefe8
Compare
Signed-off-by: addjuarez <[email protected]>
…t a new workflow (dapr#945) * add NewWorkflowOption Signed-off-by: kaibocai <[email protected]> * fix style Signed-off-by: kaibocai <[email protected]> * add unit test Signed-off-by: kaibocai <[email protected]> * add more unit tests for improving coverage Signed-off-by: kaibocai <[email protected]> --------- Signed-off-by: kaibocai <[email protected]> Signed-off-by: addjuarez <[email protected]>
* Updated pre-requisite link to Dapr CLI Signed-off-by: Michaël Hompus <[email protected]> * Update JDK list to match all other examples Signed-off-by: Michaël Hompus <[email protected]> --------- Signed-off-by: Michaël Hompus <[email protected]> Signed-off-by: addjuarez <[email protected]>
Signed-off-by: addjuarez <[email protected]>
* add determinstic UUID generation Signed-off-by: kaibocai <[email protected]> * add unit test to improve coverage Signed-off-by: kaibocai <[email protected]> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <[email protected]> --------- Signed-off-by: kaibocai <[email protected]> Signed-off-by: kaibocai <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: addjuarez <[email protected]>
Signed-off-by: MregXN <[email protected]> Signed-off-by: addjuarez <[email protected]>
Signed-off-by: MregXN <[email protected]> Signed-off-by: addjuarez <[email protected]>
* fix flaky it MethodInvokeIT Signed-off-by: MregXN <[email protected]> * add debug print Signed-off-by: MregXN <[email protected]> * add debug print Signed-off-by: MregXN <[email protected]> * add more waiting time Signed-off-by: MregXN <[email protected]> * wait before invoke Signed-off-by: MregXN <[email protected]> * wait for health before invoke Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: addjuarez <[email protected]>
Signed-off-by: addjuarez <[email protected]>
addjuarez
force-pushed
the
workflowLogging
branch
from
550b58a
to
878225d
Compare
artursouza
requested changes
Dec 19, 2023
sdk-workflows/src/main/java/io/dapr/workflows/runtime/WorkflowRuntimeBuilder.java
Outdated
Show resolved
Hide resolved
artursouza
approved these changes
Dec 22, 2023
artursouza
previously approved these changes
Jan 8, 2024
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
============================================
+ Coverage 77.56% 77.60% +0.03%
- Complexity 1569 1570 +1
============================================
Files 144 144
Lines 4757 4765 +8
Branches 554 554
============================================
+ Hits 3690 3698 +8
Misses 781 781
Partials 286 286 ☔ View full report in Codecov by Sentry. |
artursouza
approved these changes
Feb 16, 2024
artursouza
added a commit
to artursouza/java-sdk
that referenced
this pull request
Feb 19, 2024
* Show registered workflow Signed-off-by: addjuarez <[email protected]> * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (dapr#945) * add NewWorkflowOption Signed-off-by: kaibocai <[email protected]> * fix style Signed-off-by: kaibocai <[email protected]> * add unit test Signed-off-by: kaibocai <[email protected]> * add more unit tests for improving coverage Signed-off-by: kaibocai <[email protected]> --------- Signed-off-by: kaibocai <[email protected]> Signed-off-by: addjuarez <[email protected]> * Update CLI link in example readme's (dapr#951) * Updated pre-requisite link to Dapr CLI Signed-off-by: Michaël Hompus <[email protected]> * Update JDK list to match all other examples Signed-off-by: Michaël Hompus <[email protected]> --------- Signed-off-by: Michaël Hompus <[email protected]> Signed-off-by: addjuarez <[email protected]> * remove static Signed-off-by: addjuarez <[email protected]> * Add determinstic UUID generation (dapr#947) * add determinstic UUID generation Signed-off-by: kaibocai <[email protected]> * add unit test to improve coverage Signed-off-by: kaibocai <[email protected]> * update grpc version to 1.59.0 to be compatible updated durabletask-java Signed-off-by: kaibocai <[email protected]> --------- Signed-off-by: kaibocai <[email protected]> Signed-off-by: kaibocai <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: addjuarez <[email protected]> * fix flaky integration test ActorExceptionIT (dapr#954) Signed-off-by: MregXN <[email protected]> Signed-off-by: addjuarez <[email protected]> * fix flaky it ActorReminderRecovery (dapr#958) Signed-off-by: MregXN <[email protected]> Signed-off-by: addjuarez <[email protected]> * fix flaky integration test MethodInvokeIT (dapr#959) * fix flaky it MethodInvokeIT Signed-off-by: MregXN <[email protected]> * add debug print Signed-off-by: MregXN <[email protected]> * add debug print Signed-off-by: MregXN <[email protected]> * add more waiting time Signed-off-by: MregXN <[email protected]> * wait before invoke Signed-off-by: MregXN <[email protected]> * wait for health before invoke Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: addjuarez <[email protected]> * Fix errors Signed-off-by: addjuarez <[email protected]> * make thead safe * Fix code and test. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: addjuarez <[email protected]> Signed-off-by: kaibocai <[email protected]> Signed-off-by: Michaël Hompus <[email protected]> Signed-off-by: kaibocai <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: kaibocai <[email protected]> Co-authored-by: Michaël Hompus <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: MregXN <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]>
3 tasks
artursouza
added a commit
that referenced
this pull request
Feb 19, 2024
* Show registered workflow * Add `NewWorkflowOption` to config version, time, input, etc when start a new workflow (#945) * add NewWorkflowOption * fix style * add unit test * add more unit tests for improving coverage --------- * Update CLI link in example readme's (#951) * Updated pre-requisite link to Dapr CLI * Update JDK list to match all other examples --------- * remove static * Add determinstic UUID generation (#947) * add determinstic UUID generation * add unit test to improve coverage * update grpc version to 1.59.0 to be compatible updated durabletask-java --------- * fix flaky integration test ActorExceptionIT (#954) * fix flaky it ActorReminderRecovery (#958) * fix flaky integration test MethodInvokeIT (#959) * fix flaky it MethodInvokeIT * add debug print * add debug print * add more waiting time * wait before invoke * wait for health before invoke --------- * Fix errors * make thead safe * Fix code and test. --------- Signed-off-by: addjuarez <[email protected]> Signed-off-by: kaibocai <[email protected]> Signed-off-by: Michaël Hompus <[email protected]> Signed-off-by: kaibocai <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: addjuarez <[email protected]> Co-authored-by: kaibocai <[email protected]> Co-authored-by: Michaël Hompus <[email protected]> Co-authored-by: MregXN <[email protected]> Co-authored-by: Dapr Bot <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added in basic logging for workflow to log the registered activities and registered workflows.
Mimicking changes being added here dapr/dotnet-sdk#1176
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: