Add bulk subscriber over gRPC to examples #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MregXN <[email protected]>
Signed-off-by: MregXN <[email protected]>
MregXN
force-pushed
the
bulk-subscriber-grpc
branch
from
6c70664
to
b3308cd
Compare
Signed-off-by: MregXN <[email protected]>
MregXN
force-pushed
the
bulk-subscriber-grpc
branch
from
b3308cd
to
714ea82
Compare
MregXN
force-pushed
the
bulk-subscriber-grpc
branch
from
1e9b8c4
to
2f2a0ed
Compare
artursouza
previously approved these changes
Sep 11, 2023
Signed-off-by: Artur Souza <[email protected]>
artursouza
previously approved these changes
Sep 11, 2023
|
@MregXN - Looks like there are some conflicts to be resolved. Then I think it can be merged since it's already approved |
Signed-off-by: MregXN <[email protected]>
Signed-off-by: MregXN <[email protected]>
the conflicts have been resolved. it is ready to merge. @artursouza @mukundansundar |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #871 +/- ##
============================================
- Coverage 77.31% 76.29% -1.03%
+ Complexity 1537 1463 -74
============================================
Files 143 138 -5
Lines 4642 4497 -145
Branches 541 524 -17
============================================
- Hits 3589 3431 -158
- Misses 778 784 +6
- Partials 275 282 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add bulk subscriber over gRPC to examples and modified the README.md to cover validation of both http subscriber and grpc subscriber.
Issue reference
Please reference the issue #864 and #865.