Update project-reactor dependency & fix deprecated calls #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating project reactor dependency to work with spring boot 3, replacing deprecated calls to subscriberContext Signed-off-by: Jan Czapla <[email protected]>
Gonzoe79
changed the title
|
@Gonzoe79 can you fix the checkstyle violations? |
Signed-off-by: Jan Czapla <[email protected]>
Signed-off-by: Jan Czapla <[email protected]>
Signed-off-by: Jan Czapla <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #816 +/- ##
============================================
+ Coverage 77.62% 77.72% +0.09%
- Complexity 1161 1164 +3
============================================
Files 105 105
Lines 3647 3663 +16
Branches 419 419
============================================
+ Hits 2831 2847 +16
Misses 603 603
Partials 213 213
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Although this is a breaking change due to the dependency change, I can accept this PR if the integration tests pass. Please, take a look that they are all failing consistently. |
|
gentle ping - @Gonzoe79 |
|
We already upgraded to Springboot 3. Closing PR. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating project reactor dependency to work with spring boot 3, replacing deprecated calls to subscriberContext
Signed-off-by: Jan Czapla [email protected]
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: