Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pubsub routing support #631

Merged
merged 4 commits into from
Jun 23, 2022
Merged

Adding pubsub routing support #631

merged 4 commits into from
Jun 23, 2022

Conversation

pkedy
Copy link
Member

@pkedy pkedy commented Sep 15, 2021

Description

Adding a rule attribute to the topic annotation to utilize PubSub routing.

Issue reference

dapr/dapr#2582

Checklist

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@pkedy pkedy requested review from a team as code owners September 15, 2021 16:30
Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Just some minor comments.

@johnou
Copy link

johnou commented Jan 26, 2022

ping @pkedy

@artursouza
Copy link
Member

This PR is idle and available to anyone that would like to take over and then create a new PR to replace this one.

@artursouza artursouza force-pushed the pubsub_routing branch 2 times, most recently from dd9e31e to b7a858f Compare June 22, 2022 22:39
pkedy and others added 2 commits June 22, 2022 15:43
* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
@artursouza artursouza force-pushed the pubsub_routing branch 3 times, most recently from 016fafd to fe9d4c7 Compare June 22, 2022 23:38
Signed-off-by: Artur Souza <[email protected]>
@artursouza artursouza added this to the v1.6 milestone Jun 23, 2022
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #631 (cbf2be6) into master (a9672c4) will decrease coverage by 1.85%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #631      +/-   ##
============================================
- Coverage     78.19%   76.34%   -1.86%     
  Complexity     1117     1117              
============================================
  Files            97      101       +4     
  Lines          3417     3500      +83     
  Branches        399      407       +8     
============================================
  Hits           2672     2672              
- Misses          547      630      +83     
  Partials        198      198              
Impacted Files Coverage Δ
...java/io/dapr/springboot/DaprBeanPostProcessor.java 40.29% <0.00%> (-1.89%) ⬇️
.../src/main/java/io/dapr/springboot/DaprRuntime.java 0.00% <0.00%> (ø)
...va/io/dapr/springboot/DaprSubscriptionBuilder.java 0.00% <0.00%> (ø)
...src/main/java/io/dapr/springboot/DaprTopicKey.java 0.00% <0.00%> (ø)
.../main/java/io/dapr/springboot/DaprTopicRoutes.java 0.00% <0.00%> (ø)
...rc/main/java/io/dapr/springboot/DaprTopicRule.java 0.00% <0.00%> (ø)
...java/io/dapr/springboot/DaprTopicSubscription.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9672c4...cbf2be6. Read the comment docs.

@artursouza artursouza merged commit 2235e3d into dapr:master Jun 23, 2022
naah69 pushed a commit to naah69/dapr-java-sdk that referenced this pull request Jul 7, 2022
* Adding pubsub routing support

Signed-off-by: Artur Souza <[email protected]>

* remove deprecated classes (dapr#704)

* remove deprecated classes

Signed-off-by: Mukundan Sundararajan <[email protected]>

* remove builder class ref in ITs

Signed-off-by: Mukundan Sundararajan <[email protected]>

* fix setter in IT

Signed-off-by: Mukundan Sundararajan <[email protected]>
Signed-off-by: Artur Souza <[email protected]>

* Address PR comments.

Signed-off-by: Artur Souza <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Artur Souza <[email protected]>
Signed-off-by: naah69 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants