-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pubsub routing support #631
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall. Just some minor comments.
sdk-springboot/src/main/java/io/dapr/springboot/DaprSubscriptionBuilder.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprSubscriptionBuilder.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicSubscription.java
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprSubscriptionBuilder.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicKey.java
Outdated
Show resolved
Hide resolved
sdk-springboot/src/main/java/io/dapr/springboot/DaprTopicRule.java
Outdated
Show resolved
Hide resolved
ping @pkedy |
This PR is idle and available to anyone that would like to take over and then create a new PR to replace this one. |
dd9e31e
to
b7a858f
Compare
Signed-off-by: Artur Souza <[email protected]>
* remove deprecated classes Signed-off-by: Mukundan Sundararajan <[email protected]> * remove builder class ref in ITs Signed-off-by: Mukundan Sundararajan <[email protected]> * fix setter in IT Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Artur Souza <[email protected]>
016fafd
to
fe9d4c7
Compare
Signed-off-by: Artur Souza <[email protected]>
fe9d4c7
to
18f5b45
Compare
Codecov Report
@@ Coverage Diff @@
## master #631 +/- ##
============================================
- Coverage 78.19% 76.34% -1.86%
Complexity 1117 1117
============================================
Files 97 101 +4
Lines 3417 3500 +83
Branches 399 407 +8
============================================
Hits 2672 2672
- Misses 547 630 +83
Partials 198 198
Continue to review full report at Codecov.
|
* Adding pubsub routing support Signed-off-by: Artur Souza <[email protected]> * remove deprecated classes (dapr#704) * remove deprecated classes Signed-off-by: Mukundan Sundararajan <[email protected]> * remove builder class ref in ITs Signed-off-by: Mukundan Sundararajan <[email protected]> * fix setter in IT Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Artur Souza <[email protected]> * Address PR comments. Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: naah69 <[email protected]>
Description
Adding a rule attribute to the topic annotation to utilize PubSub routing.
Issue reference
dapr/dapr#2582
Checklist