Implements full spec of gRPC endpoint. #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artursouza
force-pushed
the
update_grpc_env
branch
from
12e5047
to
c0af545
Compare
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
update_grpc_env
branch
from
c0af545
to
c061074
Compare
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
Signed-off-by: Artur Souza <[email protected]>
artursouza
force-pushed
the
update_grpc_env
branch
from
89d782f
to
45be0ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1042 +/- ##
============================================
+ Coverage 76.91% 77.79% +0.88%
+ Complexity 1592 1570 -22
============================================
Files 145 144 -1
Lines 4843 4797 -46
Branches 562 563 +1
============================================
+ Hits 3725 3732 +7
+ Misses 821 780 -41
+ Partials 297 285 -12 ☔ View full report in Codecov by Sentry. |
43 tasks
cicoyle
reviewed
May 28, 2024
| ports: | ||
| - "2181:2181" | ||
| - 22181:2181 |
There was a problem hiding this comment.
is the extra 2 there intentional? in 22181
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements full spec of gRPC endpoint.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1028
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: