-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(wasm): support http(s) fetch of Wasm files #3625
Conversation
|
||
```yaml | ||
apiVersion: dapr.io/v1alpha1 | ||
kind: Component | ||
metadata: | ||
name: wasm | ||
spec: | ||
type: bindings.wasm | ||
version: v1 | ||
metadata: | ||
- name: url | ||
value: "https://github.com/vmware-labs/webassembly-language-runtimes/releases/download/ruby%2F3.2.0%2B20230215-1349da9/ruby-3.2.0-slim.wasm" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was not able to test this snippet though (see discord thread)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the documentation to actually reflect the implementation. The issue is the original example was tokenizing naively at ,
, causing the following arglist to be split incorrectly:
"args": "-ne,'print \"Hello, \"; print'" => [-ne] ['print "Hello] [ "; print]
a working example is instead:
"args": "-ne,print \"Hello \"; print" => [-ne] [print "Hello "; print]
notice how quotes are currently being ignored. This is obviously suboptimal and should be fixed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial review
daprdocs/content/en/reference/components-reference/supported-bindings/wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-bindings/wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
daprdocs/content/en/reference/components-reference/supported-middleware/middleware-wasm.md
Outdated
Show resolved
Hide resolved
Signed-off-by: Edoardo Vacchi <[email protected]>
Signed-off-by: Edoardo Vacchi <[email protected]>
Stale PR, paging all reviewers |
@Taction - Can you please review this? |
Signed-off-by: Edoardo Vacchi <[email protected]>
value: "https://github.com/vmware-labs/webassembly-language-runtimes/releases/download/ruby%2F3.2.0%2B20230215-1349da9/ruby-3.2.0-slim.wasm" | ||
``` | ||
|
||
Assuming that you started your Wasm Binding at port 3500, you'd run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that you started your Dapr at port 3500 with the Wasm Binding, you'd run:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am rephrasing because now that I am re-reading that, the phrasing was awkward to begin with:
Assuming that you wanted to start your Dapr at port 3500 with the Wasm Binding, you'd run:
LGTM overall, just a nit change. |
Signed-off-by: Edoardo Vacchi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Edoardo Vacchi [email protected]
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Update wasm middleware/bindings in accordance to dapr/components-contrib#3005
Issue reference
Related issue: dapr/components-contrib#2700